-
Notifications
You must be signed in to change notification settings - Fork 19
NO-JIRA: Logging-ui-plugin test using real data #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e598ce to
74d54a2
Compare
86bc31f to
856f0b1
Compare
|
/retest |
|
@anpingli There are some errors coming from the package-lock.json file, this is from prow logs:
|
3294a38 to
cf23167
Compare
cf23167 to
cc7ed85
Compare
web/cypress/e2e/logging/logs-adminConsole-AggregatedLogs-admin.cy.ts
Outdated
Show resolved
Hide resolved
27d9043 to
352c1a6
Compare
352c1a6 to
ee72376
Compare
ee72376 to
3d1f633
Compare
|
@etmurasaki @jgbernalp Refactored the program to improve readability and maintainability, please take a look again. |
eb8389d to
be6f2a5
Compare
|
/retest |
be6f2a5 to
aba0076
Compare
|
@anpingli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@anpingli: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anpingli, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label qe-approved |
Uh oh!
There was an error while loading. Please reload this page.